Add jump to line number in preview#233
Merged
Merged
Conversation
Adds an L keybinding in the preview panel that opens a prompt to type a line number and jump straight to it. The target line is centered in the viewport when possible. Works in file, diff, and blame views, and with word wrap or line numbers on or off since it indexes source lines. Closes #223 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Replace the repeated 'esc'/'escape' key-name literals in the edit, selection, and go-to-line handlers with keyEsc/keyEscape constants so goconst passes, matching the existing keyDown convention. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a jump to line number feature to the preview panel. Press
Lto open a prompt, type a line number, and press Enter to jump straight there. The target line is centered in the viewport when there is room.Why
Scrolling to a specific line in a long file or diff is slow. When a build error or review comment points at a line number, you want to go there directly instead of paging through the file.
How
Lopens an inline prompt at the bottom of the preview (Go to line:).Testing
gotoline_test.gocovers clamping, centering offset, prompt open/type/commit, escape cancel, empty and non-digit rejection, and prompt rendering.go build ./...,go vet ./..., preview and keybindings packages pass, gofumpt clean.Closes #223