Improve whitespace trimming performance#225
Merged
jonschlinkert merged 4 commits intojonschlinkert:devfrom Sep 27, 2016
dpkirchner:dev
Merged
Improve whitespace trimming performance#225jonschlinkert merged 4 commits intojonschlinkert:devfrom dpkirchner:dev
jonschlinkert merged 4 commits intojonschlinkert:devfrom
dpkirchner:dev
Conversation
added 4 commits
July 22, 2016 15:14
The performance impact of the previous method was only felt on excessively large lines of empty space surrounded by words. i.e. 'a b \n' but with 20k spaces between a and b.
The performance impact of the previous method was only felt when including absurd amounts of whitespace inside of table cells, on the order of 20k or so spaces between pipes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excessive whitespace requires a lot of CPU to process. These commits replace the
replacecalls withsubstringcalls.