Fix joomla installation folder removal false positives #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command was wrong. It was waiting for a visibility change in the element, but the right check is not to check if visibilty is changed but if the element has appeared in the DOM.
javigomez
changed the title
Member
There was a problem hiding this comment.
I tried to make this work, but it always failed, did you verify at your end?
puneet0191
added a commit
that referenced
this pull request
Aug 3, 2015
Fix joomla installation folder removal false positives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command was wrong. It was waiting for a visibility change in the element, but the right check is not to check if visibilty is changed but if the element has appeared in the DOM.