Add wait time, to support tests on windows with wamp. #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to add some wait times after the choosen, because else the tests will fail on wamp.
src/JoomlaBrowser.php
Outdated
Member
There was a problem hiding this comment.
We are already waiting here.
Contributor
Author
There was a problem hiding this comment.
ok thnx, didn't know it was time waiting. will test it again, and will update the code.
Contributor
Author
|
Updated the code, + added hide the statistics info message |
src/JoomlaBrowser.php
Outdated
Contributor
There was a problem hiding this comment.
we are waiting in line 162 for the Text to appear, I think this one is not needed.
Contributor
Author
|
code updated |
Contributor
|
looks 👍 to me |
Member
|
Thanks 😄 |
Member
|
merging! 👍 |
puneet0191
added a commit
that referenced
this pull request
Jan 13, 2016
Add wait time, to support tests on windows with wamp.
Contributor
There was a problem hiding this comment.
The removal of this line caused the browser to get stuck during installation:
I tested running the tests with JoomlaBrowser in the commit previous to this one and it works:
I'm sending the fix right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add some wait times after the choosen, because else the tests
will fail on wamp.