Skip to content

Add wait time, to support tests on windows with wamp. #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2016
Merged

Add wait time, to support tests on windows with wamp. #89

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28da15c
Add wait time, to support tests on windows with wamp.
810 Dec 16, 2015
172437c
Add disablestatistics
810 Dec 16, 2015
d32db0b
Update code
810 Dec 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/JoomlaBrowser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,16 +129,14 @@ public function installJoomla()
$this->debug('I wait for Main Configuration');
$I->waitForElement('#jform_language', 10);
// Wait for chosen to render the field
$I->wait(1);
$I->debug('I select dk-DK as installation language');
Copy link
Contributor

@javigomez javigomez Jan 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of this line caused the browser to get stuck during installation:

screen shot 2016-01-15 at 11 57 11

I tested running the tests with JoomlaBrowser in the commit previous to this one and it works:

screen shot 2016-01-15 at 11 57 45

I'm sending the fix right now.

// Select a random language to force reloading of the lang strings after selecting English
$I->selectOptionInChosen('#jform_language', 'Danish (DK)');
$I->waitForText('Generel konfiguration', 10, 'h3');
$I->waitForText('Generel konfiguration', 60, 'h3');
// Wait for chosen to render the field
$I->wait(1);
$I->debug('I select en-GB as installation language');
$I->selectOptionInChosen('#jform_language', 'English (United Kingdom)');
$I->waitForText('Main Configuration', 10, 'h3');
$I->waitForText('Main Configuration', 60, 'h3');
$this->debug('I fill Site Name');
$I->fillField(['id' => 'jform_site_name'], 'Joomla CMS test');
$this->debug('I fill Site Description');
Expand Down Expand Up @@ -855,4 +853,17 @@ public function verifyAvailableTabs($expectedTabs, $tabsLocator = ['xpath' => "/
$I->assertEquals($expectedTabs, $actualArrayOfTabs, "Tab Labels do not match on edit view of" . $url);
$I->debug('Verify the Tabs');
}

/**
* Hide the statistics info message
*
* @note: doAdminLogin() before
*/
public function disableStatistics()
{
$I = $this;
$this->debug('I click on never');
$I->waitForElement(['link' => 'Never'], 60);
$I->click(['link' => 'Never']);
Copy link
Contributor

@javigomez javigomez Dec 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before clicking we need to make sure the link is already available.

we need a:

$I->waitForElement(['link' => 'Never'], 60)

}
}