[5.3] #44957 fix changes added custom Trim of Ui image #45167
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
Contributor
|
Please add some screenshots to illustrate the before and after |
Member
|
This pull request has been automatically rebased to 5.3-dev. |
HLeithner
changed the title
Contributor
|
I have absolutely no idea what you are trying to do here. It seems to be nothing to do with the referenced issue |
Contributor
|
Finally worked out what the changes here do and they are NOTHING to do with what you are trying to do as you are editing the wrong file completely. The file you are editing is used to display this
|
Contributor
|
even if you were editing the correct file this is not the way to change the displayed length of a filename. The current css method is the correct way to do it. Your method can result in multiple images being displayed as the same filename etc etc |
Contributor
|
Closing as this is not the correct fix. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44957 .
Summary of Changes
Added changes in code of default.php file of adminstartor/components/com_media/tmpl/file/default.php with custom logic for trimming the file name
Actual result BEFORE applying this Pull Request
Trimming of text is full
Expected result AFTER applying this Pull Request
Trimmed the text upto UI/UX view
This is the after applying pr result in previous the image is not with me after applying pr the result we get is trimmed text view of image accordance to UI/UX and the code is also optimized and changed
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed