Migrate to pyproject.toml and update Python versions to 3.9 and 3.10 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dropped support py3.6, py3.7, and py3.8 as supporting them in 2025 is very challenging - Added support for py3.10 - Replaced setup.py, setup.cfg, and tox.ini with pyproject.toml for modern packaging and configuration. - Updated CI workflow to test on Python 3.9 and 3.10 - added .python-version - Added test command to Makefile, which uses uv instead of tox for testing multiple python versions - Adjusted Makefiel to use ruff instead of black, isort, and flake8 - Refactored code for improved type hinting and formatting consistency.
Owner
|
Seems like there are some format issues |
pydanny
force-pushed
the
modernize-tooling-plus-python-version-changes
branch
from
322168f to
0f4e4e3
Compare
Contributor
Author
|
Formatting issues and that my Python matrix design of This should work now. I created a standalone repo unconnected to this one where I could trigger actions at will. This new workflow design was able to identify bad code. Once this PR is accepted my pull requests won't need your approval, so this should go faster. 😄 |
Contributor
Author
|
By approval, I mean in order to run GH actions... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is the first of several pull requests whose intent is to modernize this library so current FastAPI projects can leverage the excellent asyncpg library in a consistent manner.
This change is designed to bring fastapi-asyncpg into the realm of modern Python tooling. It did require dropping support of py3.6, py3.7, and py3.8, however, those versions haven't been officially supported in years.
Notably, this follows this replacement chart, embracing the same pattern used by FastAPI, Pydantic, and the growing majarity of the Python world:
A summary of changes: