Skip to content

fix(gh-cli): print pull request URLs - #172

Merged
joshjohanning merged 2 commits into
mainfrom
joshjohanning-urban-winner
Aug 31, 2026
Merged

fix(gh-cli): print pull request URLs#172
joshjohanning merged 2 commits into
mainfrom
joshjohanning-urban-winner

Conversation

@joshjohanning

Copy link
Copy Markdown
Owner

Summary

  • print complete GitHub URLs when matching pull requests are found
  • use clickable URLs in merge, auto-merge, failure, skip, and dry-run output

Copilot AI lite review requested due to automatic review settings August 31, 2026 15:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

One skip-path message still prints $repo#$pr_number instead of a clickable PR URL, which conflicts with the PR’s stated output goal.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1 Low severity

New issues introduced by this change (1)
Severity Finding
Low severity gh-cli/​merge-pull-requests-by-title.sh — The fork-based skip message still prints $repo#$pr_number, which isn’t a clickable URL (and…
What changed in this PR

This PR updates the gh-cli/merge-pull-requests-by-title.sh script to print fully-qualified pull request URLs in output so results are clickable when PRs are found and when merge/auto-merge actions are taken.

Changes:

  • Add a pr_url variable for each matched PR and include it in “Found PR” output
  • Replace $repo#$pr_number references with $pr_url in merge, auto-merge, failure, skip, and dry-run messaging (partially)
File Description
gh-cli/​merge-pull-requests-by-title.sh Introduces pr_url and updates merge-related output to show full PR URLs

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread gh-cli/merge-pull-requests-by-title.sh

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The stated PR goal (URLs in merge, auto-merge, failure, skip, and dry-run output) is not fully met because some messages still print $repo#$pr_number instead of a clickable URL.

Review tier: Lite
Findings: None

Issues resolved since last review (1)
Severity Finding
Low severity gh-cli/​merge-pull-requests-by-title.sh — The fork-based skip message still prints $repo#$pr_number, which isn’t a clickable URL (and… View resolved comment
Suppressed comments (1)

gh-cli/merge-pull-requests-by-title.sh:394

  • The PR description says output should use clickable URLs for merge, auto-merge, failure, skip, and dry-run, but this change only updates some messages. In this script there are still outputs that print $repo#$pr_number (e.g., status-check failure skip and several bump-version failure paths), so the behavior doesn’t fully match the stated goal.
    pr_url="https://github.com/$repo/pull/$pr_number"
    echo "  📋 Found PR #$pr_number: $pr_title (by $pr_author) - $pr_url"

@joshjohanning
joshjohanning disabled the stack merge August 31, 2026 18:27
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: bed3e0ff-d6c7-426a-8591-4c4b8e74705c
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: bed3e0ff-d6c7-426a-8591-4c4b8e74705c
@joshjohanning
joshjohanning force-pushed the joshjohanning-urban-winner branch from f2033b9 to 767f760 Compare August 31, 2026 18:27
joshjohanning added a commit that referenced this pull request Aug 31, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 14d24b4b-af6d-42d0-8743-bbda5d4767a8
@joshjohanning
joshjohanning merged commit 5bea905 into main Aug 31, 2026
6 checks passed
@joshjohanning
joshjohanning deleted the joshjohanning-urban-winner branch August 31, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants