Fix NumberFormatException for manifest GIDs exceeding Long.MAX_VALUE#8
Merged
joshuatam merged 1 commit intojoshuatam:gamenative-latestfrom Mar 30, 2026
Conversation
jeremybernstein
force-pushed
the
jb/fix-unsigned-manifest-id
branch
from
1df3e00 to
7c8236b
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSteam3DepotManifestparses manifest GIDs viaString.toLong()which throwsNumberFormatException for values > 9223372036854775807
toULong().toLong()to preservethe bit pattern as a signed long
Test case
Neverwinter Nights: Enhanced Edition (app 3700) — depot 3701 has GID
11172694944737444218, depot 3707 has17259200295595460348. Both overflow signed long.Confirmed via
steamcmd +login anonymous +app_info_print 3700.