fix: handle unsigned 64-bit manifest IDs throughout the pipeline#9
Merged
joshuatam merged 1 commit intojoshuatam:gamenative-latestfrom Apr 1, 2026
Conversation
add Util file path tests for save/load with manifest IDs > Long.MAX_VALUE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NumberFormatExceptioningetSteam3DepotManifestparsing. That fix was incomplete — manifest IDs still rendered as negative signed longs in CDN URLs, file paths, log messages, and binary KeyValue UINT64 deserialization.ClientURL construction,Utilsave/load manifest filenames,DepotDownloaderlog messages,Steam3Sessionlog messages, andKeyValue.tryReadAsBinaryUINT64 → string conversion.Apologies for the incomplete fix in #8 — should have traced the full pipeline the first time.
Test plan
ManifestIdUnsignedTest— CDN URL uses unsigned representation (parameterized)ManifestIdUnsignedTest— CDN URL without request codeManifestIdUnsignedTest— KeyValue binary UINT64 roundtripsUtilManifestFilePathTest— save/load manifest filenames use unsigned ID