NAMS: well-known endpoint, X-Workspace-Id fix, live-integration test scaffold#136
Merged
Merged
Conversation
…ration test scaffold A live NAMS SaaS account became available mid-session, revealing that an account-wide API key needs X-Workspace-Id (a workspace-scoped key carries it implicitly) -- NamsOptions.WorkspaceId was captured but never attached. Adds NamsWellKnown.Endpoint (the public SaaS base URL, non-secret) and a skip-cleanly live-integration test scaffold that validates the full Phase 4-6 pipeline (identity resolution -> persistence -> recall) against the real service for the first time.
…lidation, poll resilience, conventions) - Add NamsOptionValidator.HasValidWorkspaceId: fail fast on control characters instead of a lazy FormatException on the first HTTP call. - PollUntilAsync now swallows exceptions from the polled condition itself (not just the delay), matching Neo4jIntegrationFixture.WaitForVectorIndexesAsync's established pattern -- a transient blip against the live service no longer aborts the whole bounded poll. - Drop the redundant second Category trait, remove ConfigureAwait(false) from test code, and match NamsLiveTestCollection's shape to its one direct precedent (Neo4jIntegrationCollection).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NamsWellKnown.Endpoint(public NAMS SaaS base URL, non-secret constant).NamsOptions.WorkspaceIdwas captured but never sent asX-Workspace-Id-- needed for an account-wide (admin) API key to target a specific workspace (a workspace-scoped key carries it implicitly). Also adds fail-fast validation for it.tests/AgentMemory.Tests.Integration/Nams/) that validates the full Phase 4-6 pipeline (identity resolution -> persistence -> recall) against the real NAMS SaaS, using a dedicated isolated dev workspace. Skips (never fails) whenNAMS_API_KEY/NAMS_DEV_WORKSPACE_IDaren't configured -- so it reports Skipped in CI, never runs against anything real there.Full write-up, including the 3-way self-review findings and fixes:
docs/reviews/NAMS_LiveValidationAndIntegrationTestScaffold_PlanningAndImplementationPlan.md.Test plan
dotnet build AgentMemory.slnx -c Release-- 0 warnings, 0 errorsdotnet test tests/AgentMemory.Tests.Unit-- 3209/3209 green