Fix bug not allowing users to close by clicking on backdrop#313
Closed
guyathomas wants to merge 2 commits intojossmac:masterfrom
Closed
Fix bug not allowing users to close by clicking on backdrop#313guyathomas wants to merge 2 commits intojossmac:masterfrom
guyathomas wants to merge 2 commits intojossmac:masterfrom
Conversation
guyathomas
force-pushed
the
fix-unable-to-close-backdrop-on-click
branch
2 times, most recently
from
e1adfa4 to
f96c60c
Compare
bigklubba
reviewed
Nov 20, 2019
|
|
||
| prev = () => { | ||
| prev = (event) => { | ||
| event.stopPropagation(); |
There was a problem hiding this comment.
this is needed for the close and fullscreen button as well
|
hey, any updates on this PR? 🤔 |
Collaborator
|
I'll need to test the changes and fix the linting error (unless the PR author does it), then it can be merged! |
3 tasks
Collaborator
|
Fixed by #357 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
It seems
!event.target.classList.contains(className('view')had the intention of only allowing the closing of the backdrop on clicking in a selected region (picture below). However, this area did not actually take up the entire backdrop. Instead of whitelisting allowed areas, i decided to blacklist areas that a click should not close ( previous and next buttons )Related issues (if any):
#302
Checks:
yarn run lintran successfully/srcand/examples/srcare committed