Made clicking on more parts of the backdrop dismiss modal#357
Merged
davwheat merged 4 commits intojossmac:masterfrom Mar 21, 2020
Merged
Made clicking on more parts of the backdrop dismiss modal#357davwheat merged 4 commits intojossmac:masterfrom
davwheat merged 4 commits intojossmac:masterfrom
Conversation
Contributor
Author
|
@davwheat - thanks for releasing the new versions lately! Can you take a look at this? |
Collaborator
|
Thank you so much for the PR @hsource I keep getting notifications for this repo buried under everything else, so a reminder is very useful. |
3 tasks
Collaborator
|
@k4mr4n It's already included in v1.1.0 which was released 2 weeks ago. |
|
@davwheat I have the latest version (v1.1.0) and checked the dist folder (node_modules/react-images/dist/**) and /** UPDATE */ |
Collaborator
|
Yep I realised I forgot to build before publishing 1.1.0! Sorry... 😅 |
|
no worries, thank you for this great library 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Previously, clicking on the header, the footer, or any part of the "track" above or below the image failed to dismiss the modal.
Related issues (if any):
Pull request #313: another attempt at this that relied on a blacklist rather than a whitelist. I think a whitelist is still safer, as it won't make other buttons unclickable and still leaves text in the caption selectable
Fixes #351
Checks:
yarn run lintran successfully/srcand/examples/srcare committedAlso manually tested to verify the change: