ci: actually enforce Agent Plugins conformance in the pipeline - #8
Merged
Conversation
The CI workflow invokes each validator script directly rather than running `make gate`, so adding `spec` to the Makefile target never reached CI — validate_agent_plugins.py has not run on a single push. The README claim that conformance is "enforced in CI by make spec" was therefore false when written. Adds the missing step, and an advisory one that validates against the UPSTREAM reference validator and the published JSON schemas rather than our transcription of them, so a spec revision upstream surfaces as a warning instead of silently drifting. That step is network-dependent, so it does not block; the deterministic in-repo gate does. Cherry-picked from the parallel branch on PR #4, which spotted this. Also refreshes research/coverage-matrix.md, which still carried a 2026-07-23 date and no conformance target.
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
The CI workflow invokes each validator script directly rather than running
make gate. Addingspecto the Makefile target therefore never reached CI —validate_agent_plugins.pyhas not run on a single push, including the pushes that shipped v0.2.0.That makes the README line published in #7 — "Enforced in CI by
make spec" — false at the time of writing. This PR makes it true.The plugin is conformant; that was verified by hand and by a fresh public clone. What was missing is the automation that stops it regressing.
Changes
validate_agent_plugins.pystep to.github/workflows/gate.yml.skills-refreference validator and the published JSON schemas, rather than our in-repo transcription of them. A spec revision upstream now surfaces as a warning rather than drifting silently. It is network-dependent, so it usescontinue-on-error— the deterministic in-repo gate remains the blocking one.research/coverage-matrix.md, which still carried a 2026-07-23 date and no conformance target.Credit
The
gate.ymlchange is cherry-picked from the parallel branch on #4, which caught this. #4 itself conflicts withmainand its remaining content has been superseded — see the note there.