Reset column information#31
Merged
Merged
Conversation
Collaborator
|
Hey @oneamtu, thanks for the PR!! Really helpful :) Just one thing, can you revert the changes in the Rakefile? I know those are needed for run in your environment, but if we want to change that in the repo it probably deserves it's own PR. Thanks again! |
Contributor
Author
|
Hey @kitop reverted the Rakefile! Sorry about that, I did not mean to commit it. Hopefully the checks pass now :) |
Collaborator
|
Thanks @oneamtu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, this patches an issue when you create multiple models with Temping with the same name. AR will load the column information once, but not after. Calling reset_column_information after the schema update fixes it. Let me know if there's anything I should change!
I started a new PR to re-run the Travis build, for some reason it failed and I couldn't replicate it locally.