Fix Rails 7#68
Merged
Merged
Conversation
dmytro-savochkin
force-pushed
the
fix-rails-7
branch
from
0438910 to
6c1f5cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
Previously there was added some code in #40 to handle cases when models created by Temping are cached in ActiveRecord (ActiveSupport?) reflection store.
However in Rails 7 autoloading was hugely reworked, most of the code from ActiveSupport::Dependencies was deleted as described in https://rubyonrails.org/2021/9/3/autoloading-in-rails-7-get-ready, so this whole problem seems to be gone. At the very least I can't reproduce the exception from the test case added in #40 with ActiveRecord 7 (if I just remove
ActiveSupport::Dependencies::Reference.clear!).So, let's just try removing that line for Rails >= 7.