Skip to content

Add track cover art in playlist and search results#233

Merged
jpochyla merged 3 commits intojpochyla:masterfrom
itsjunetime:add_track_cover
Dec 22, 2021
Merged

Add track cover art in playlist and search results#233
jpochyla merged 3 commits intojpochyla:masterfrom
itsjunetime:add_track_cover

Conversation

@itsjunetime
Copy link
Copy Markdown
Contributor

Screen Shot 2021-12-11 at 4 38 40 PM

This adds cover art images to tracks within playlists and search results (but not in albums), akin to the first party Spotify app (see attached image for a visual of what it looks like now). I didn't see an issue about this, but I feel it makes sense since that is what the spotify electron app does.

If you feel this is an unwanted change or should be implemented some other way, let me know and I'd be glad to discuss it :)

@confact
Copy link
Copy Markdown

confact commented Dec 15, 2021

I have been one of those who felt it was hard to read with the covers in a playlist. But Spotify has more information in the lists, so this could work. Otherwise, I would love to turn on/off this, as it is a bit distracting.

Great job, nonetheless!

@jacksongoode
Copy link
Copy Markdown
Collaborator

Looks great, and if it could be toggleable for those who want more minimalism, that would be even better!

@jpochyla
Copy link
Copy Markdown
Owner

Nice, thanks for the PR! Let's add a switch to the Preferences for this and merge?

@jpochyla
Copy link
Copy Markdown
Owner

I realized it would be a bit more involved because of the CommonCtx stuff, so I did it myself. What do you think @iandwelker?

@itsjunetime
Copy link
Copy Markdown
Contributor Author

I realized it would be a bit more involved because of the CommonCtx stuff, so I did it myself. What do you think @iandwelker?

Looks good to me! I think that adding a toggle would've been a bit over my head, so I appreciate you doing so :)

@jpochyla jpochyla merged commit 165b276 into jpochyla:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants