Clear credentials from UI after authenticating#341
Merged
Insprill merged 5 commits intojpochyla:masterfrom Jan 11, 2023
Insprill:fix/credentials
Merged
Clear credentials from UI after authenticating#341Insprill merged 5 commits intojpochyla:masterfrom Insprill:fix/credentials
Insprill merged 5 commits intojpochyla:masterfrom
Insprill:fix/credentials
Conversation
Owner
|
Hi, thanks a lot for all the PRs, great work!
I agree. |
Collaborator
Author
|
What do you think about only clearing the password if authentication fails? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When logging in initially, or after changing accounts, until psst is restarted, when the settings panel is opened, the credentials will be visible in plain text. This clears the credentials from the UI after a login attempt, no matter if it's successful or not.
If #342 gets merged then perhaps this should only clear the credentials if authentication was successful?