Don't close initial login window if authentication failed#342
Merged
jpochyla merged 1 commit intojpochyla:masterfrom Oct 12, 2022
Insprill:fix/login-window
Merged
Don't close initial login window if authentication failed#342jpochyla merged 1 commit intojpochyla:masterfrom Insprill:fix/login-window
jpochyla merged 1 commit intojpochyla:masterfrom
Insprill:fix/login-window
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initially logging in, even if authentication failed, the login window will be closed and the main window will be opened without a clear indication of why it's blank. This simply makes it so that window is only closed if authentication was successful.