Deprecate Request.failableSend()#447
Conversation
norio-nomura
force-pushed
the
nn-deprecate-request-send
branch
2 times, most recently
from
2e111f3 to
bd6b04b
Compare
| * SourceKitten now requires Xcode 9 and Swift 3.2+ to build. | ||
| [Norio Nomura](https://github.com/norio-nomura) | ||
|
|
||
| * Deprecated `Request.send()`. |
There was a problem hiding this comment.
"Please use Request.failableSend() instead."
|
|
||
| let cursorInfo = Request.cursorInfo(file: swiftUUID, offset: usrOffset, arguments: compilerArguments).send() | ||
| guard let cursorInfo = try? Request.cursorInfo(file: swiftUUID, offset: usrOffset, arguments: compilerArguments).failableSend() else { | ||
| return nil |
jpsim
left a comment
jpsim
left a comment
There was a problem hiding this comment.
👍 other than two small comments.
|
Thanks for reviews! Updated. ✨ |
|
@jpsim your CircleCI account seems to be stopped by following error:
|
jpsim
force-pushed
the
nn-deprecate-request-send
branch
from
670c917 to
f698d03
Compare
|
CircleCI support granted the jpsim GitHub org with access to the Seed plan in early October, but I've exchanged over a dozen emails with them since that point because this has never been reflected in the CircleCI settings dashboard. I just got an email from them a few minutes ago asking to check to see if it was working now, so I rebased your last commit and pushed again to see if it would run, and it did. So we should be all good now. Thanks for the PR! |
| * SourceKitten now requires Xcode 9 and Swift 3.2+ to build. | ||
| [Norio Nomura](https://github.com/norio-nomura) | ||
|
|
||
| * Deprecated `Request.send()`. Please use `Request.failableSend()` instead. |
There was a problem hiding this comment.
I feel like we should instead rename failableSend() to just send(). Throwing APIs in the Swift stdlib aren't prefixed with failable. It made sense to call it that when we had both, but now that we're removing that, I don't think it's appropriate anymore.
norio-nomura
changed the title
Request.send()Request.failableSend()
norio-nomura
force-pushed
the
nn-deprecate-request-send
branch
from
db6ee8a to
0bccc94
Compare
|
Updated! |
Some APIs changed to `throws`: * `File.format(trimmingTrailingWhitespace:useTabs:indentWidth:) throws` * `Structure.init(file:) throws` * `SyntaxMap.init(file:) throws`
norio-nomura
force-pushed
the
nn-deprecate-request-send
branch
from
0bccc94 to
2b015e8
Compare
|
Rebased. ✨ |
|
Thanks! 🙏 |
2 participants
UseRequest.failableSend()instead ofRequest.send()Change
Request.send()tothrowsSome APIs changed to
throws:File.format(trimmingTrailingWhitespace:useTabs:indentWidth:) throwsStructure.init(file:) throwsSyntaxMap.init(file:) throws