Skip to content

GitHub: Fix repo detecting regexp #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2018
Merged

GitHub: Fix repo detecting regexp #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/github.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module.exports = function( Release ) {
Release.define({
_githubApiPath: function( path ) {
var repoUrl = Release._packageUrl( "bugs" );
var repo = repoUrl.match( /github\.com\/(\w+\/\w+)/ )[ 1 ];
var repo = repoUrl.match( /github\.com\/([^/]+\/[^/]+)/ )[ 1 ];
Copy link
Member

@markelog markelog Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also use something like this – https://github.com/jonschlinkert/parse-github-url

Right?

Copy link
Member

@dmethvin dmethvin Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather look at this one-line regexp that's super clear for the case we care about than deal with a 143-line dependency that solves a much more general problem and seems to be unmaintained. Also, this regexp allows repos with leading special chars and that package does not.

Copy link
Member

@timmywil timmywil Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I prefer the regex.

Copy link
Member

@markelog markelog Feb 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, a lot of arguments against, haha

return "/repos/" + repo + "/" + path;
},

Expand Down