GitHub: Fix repo detecting regexp #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular expression detecting the repository account+name didn't allow accounts & repo names containing dashes because of matching both those parts against the /\w+/ regexp. It was updated to match everything except the slash. This made the release script fail for jQuery Color.
This was referenced Jan 31, 2018
timmywil
approved these changes
Jan 31, 2018
markelog
reviewed
Feb 1, 2018
| _githubApiPath: function( path ) { | ||
| var repoUrl = Release._packageUrl( "bugs" ); | ||
| var repo = repoUrl.match( /github\.com\/(\w+\/\w+)/ )[ 1 ]; | ||
| var repo = repoUrl.match( /github\.com\/([^/]+\/[^/]+)/ )[ 1 ]; |
Member
There was a problem hiding this comment.
We can also use something like this – https://github.com/jonschlinkert/parse-github-url
Right?
Member
There was a problem hiding this comment.
I'd rather look at this one-line regexp that's super clear for the case we care about than deal with a 143-line dependency that solves a much more general problem and seems to be unmaintained. Also, this regexp allows repos with leading special chars and that package does not.
Member
There was a problem hiding this comment.
Wow, a lot of arguments against, haha
dmethvin
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression detecting the repository account+name didn't allow
accounts & repo names containing dashes because of matching both those parts
against the /\w+/ regexp. It was updated to match everything except the slash.
This made the release script fail for jQuery Color.