Skip to content
Discussion options

You must be logged in to vote

You found a real bug, just not the one you were aiming at. The gamma safety margin is innocent here: I retired it from the vertical axis in #1224, and in your geometry it was inert anyway, because it multiplies a base height of exactly 0.0. Your cos(gamma) reasoning about true penetration is right, and the engine already divides by cos(gamma) for exactly that reason.

The actual cause is a units error in the sill term. In engine/covers/vertical.py the sill offset is computed as sill_height / tan(elevation), which is a distance measured along the ray. That gets subtracted from distance_shaded_area, which is measured perpendicular to the window ("measure from the inside of your window to whe…

Replies: 3 comments

Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Answer selected by MSL-DA
Comment options

You must be logged in to vote
0 replies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants