Skip to content

Fix: curl install cancels immediately after OS selection#35

Merged
jrock2004 merged 2 commits intomainfrom
copilot/fix-curl-install-issue
Feb 20, 2026
Merged

Fix: curl install cancels immediately after OS selection#35
jrock2004 merged 2 commits intomainfrom
copilot/fix-curl-install-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 19, 2026

When invoked via bash <(curl ...), selecting an OS would immediately print "Installation cancelled" because ui_choose echoed the prompt string to stdout, polluting the command substitution result.

os_choice=$(ui_choose "Choose your OS:" "Mac OSX" "Linux" "Exit")
# os_choice was "Choose your OS:\nMac OSX" — matched no case branch → cancelled

Changes

  • scripts/lib/gum-wrapper.sh — In all three bash fallback paths (ui_choose, ui_multi_select, select_components), redirect all prompt/menu display lines to stderr (>&2) so command substitution captures only the user's selection, not the surrounding UI text.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…itution captures only the selection

Co-authored-by: jrock2004 <655716+jrock2004@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with curl install script execution Fix: curl install cancels immediately after OS selection Feb 19, 2026
Copilot AI requested a review from jrock2004 February 19, 2026 21:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an interactive installer regression where ui_choose (and other bash fallback menus) printed prompt/menu text to stdout, corrupting command substitution results when invoked via bash <(curl ...).

Changes:

  • Redirect bash fallback prompt/menu output for ui_choose to stderr so stdout contains only the selected value.
  • Redirect bash fallback prompt/menu output for ui_multi_select to stderr so stdout contains only the selected values.
  • Redirect bash fallback prompt/menu output for select_components to stderr while preserving stdout for the final selection list.

@jrock2004 jrock2004 marked this pull request as ready for review February 20, 2026 03:16
@jrock2004 jrock2004 merged commit 06d9b42 into main Feb 20, 2026
7 of 11 checks passed
@jrock2004 jrock2004 deleted the copilot/fix-curl-install-issue branch February 20, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants