Skip to content

Switch fzf shell integration to modern fzf --zsh approach#36

Merged
jrock2004 merged 3 commits intomainfrom
copilot/fix-fzf-install-error
Feb 20, 2026
Merged

Switch fzf shell integration to modern fzf --zsh approach#36
jrock2004 merged 3 commits intomainfrom
copilot/fix-fzf-install-error

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 20, 2026

The installer was calling the legacy Homebrew-specific $(brew --prefix)/opt/fzf/install script for shell integration, which no longer exists in modern fzf installs and is the wrong approach regardless of platform.

Changes

  • scripts/components/shell.shsetup_fzf() no longer runs the legacy install script. It now checks whether the fzf binary is present and logs the result. fzf is already installed via the package manager step (packages/common.txt); shell integration is owned by .zshrc.

  • files/.zshrc — Replaces plug "zap-zsh/fzf" (fragile plugin that probes a list of hardcoded static paths) with the canonical one-liner from the official fzf docs:

# Set up fzf key bindings and fuzzy completion
command -v fzf &> /dev/null && source <(fzf --zsh)

This works across all package managers (brew, apt, pacman, dnf), always uses the scripts bundled with the installed fzf version (≥ 0.48.0), and gracefully no-ops when fzf is absent. The stale commented-out ~/.fzf.zsh sourcing line is also removed.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • junegunn.github.io
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: jrock2004 <655716+jrock2004@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix FZF installation error in shell script Guard against missing fzf Homebrew install script in setup_fzf Feb 20, 2026
Copilot AI requested a review from jrock2004 February 20, 2026 03:30
Co-authored-by: jrock2004 <655716+jrock2004@users.noreply.github.com>
Copilot AI changed the title Guard against missing fzf Homebrew install script in setup_fzf Switch fzf shell integration to modern fzf --zsh approach Feb 20, 2026
@jrock2004 jrock2004 marked this pull request as ready for review February 20, 2026 03:36
@jrock2004 jrock2004 merged commit 10e4bd7 into main Feb 20, 2026
@jrock2004 jrock2004 deleted the copilot/fix-fzf-install-error branch February 20, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants