Switch fzf shell integration to modern fzf --zsh approach#36
Merged
Conversation
Co-authored-by: jrock2004 <655716+jrock2004@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix FZF installation error in shell script
Guard against missing fzf Homebrew install script in setup_fzf
Feb 20, 2026
Co-authored-by: jrock2004 <655716+jrock2004@users.noreply.github.com>
Copilot
AI
changed the title
Guard against missing fzf Homebrew install script in setup_fzf
Switch fzf shell integration to modern Feb 20, 2026
fzf --zsh approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer was calling the legacy Homebrew-specific
$(brew --prefix)/opt/fzf/installscript for shell integration, which no longer exists in modern fzf installs and is the wrong approach regardless of platform.Changes
scripts/components/shell.sh—setup_fzf()no longer runs the legacy install script. It now checks whether thefzfbinary is present and logs the result. fzf is already installed via the package manager step (packages/common.txt); shell integration is owned by.zshrc.files/.zshrc— Replacesplug "zap-zsh/fzf"(fragile plugin that probes a list of hardcoded static paths) with the canonical one-liner from the official fzf docs:This works across all package managers (brew, apt, pacman, dnf), always uses the scripts bundled with the installed fzf version (≥ 0.48.0), and gracefully no-ops when fzf is absent. The stale commented-out
~/.fzf.zshsourcing line is also removed.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
junegunn.github.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.