Using JSR223 ScriptEngine interface has no way to clean up resources

[ccutrer]

Expected Behavior

I embed JRuby into openHAB, using the JSR223 interface (since that's how openHAB handles several different scripting languages). A new ScriptEngine is created for each script, including if it's reloaded because I've changed it. openHAB's core code that manages scripts will check if the ScriptEngine implements AutoCloseable when it's unloading a script, and call close() on it if it does. But JRubyEngine doesn't implement AutoCloseable, nor does it have any way to access the ScriptingContainer in order for me to call terminate myself. I would expect it to implement AutoCloseable, and calling close() on the engine will just call container.terminate().

Actual Behavior

When I reload a lot of scripts, my memory usage goes up, and eventually I get to the point where GC is using 100% CPU because it's having such a hard time freeing up resources from old engines.

[enebo]

Yeah. This is the first I have heard of it but I see no reason why we cannot add AutoCloseable to our embedding code. It sounds like you have dug into this a bit. Want to try and make a PR? As you said it looks as simple as calling terminate in close.

[headius]

Good catch!