Merged
Conversation
d52edfa to
20c6554
Compare
Member
|
module specs and an io spec seems to fail : ... also did you test this on Windows (since you removed some windows: tagged) ? |
Contributor
Author
20c6554 to
2a7dc93
Compare
Contributor
Author
|
@kares okay, I left windows tags intact, because I couldn't run specs on windows (I tried but all tasks failed with various errors). |
Member
|
Wow...I love to see tags go away :-) Once this runs green we'll merge. Thanks for restoring the Windows tags. |
2a7dc93 to
e40d92d
Compare
Contributor
Author
|
@headius travis is green |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.