Integrate WASM-based Prism parser into standard build#9374
Merged
Conversation
This integrates jruby-prism 2.0 by shading it into our main JRuby jar and loading it from there. Incoming packages considered to be for internal use are moved under `org.jruby.internal`. The output of parser statistics now shows the actual class of the parser, since either or both can be activated now.
If this is parsed by Prism, it's a ProgramNode contained in a ParseResult, so just use the ParseResult.
Probably just missing some place where warn should be called during parse. We'll fix it in post.
JRuby 10.0.5.0 moves to "provided" scope in jruby-prism, since it is only needed to compile.
This should resolve the remaining issues with dependency convergence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the integration of Prism parser wrapper libraries from the jruby-prism project by shading it in and including the new WASM support and Chicory libraries.
This is a prototype of how it should eventually look and this PR is intended to iterate.
Notable behavior changes so far:
-Xparser.prismbut the dynamic library is not configured or present, it will fall back on the wasm parser.-Xparser.prism.wasmthe wasm parser will be used.The artifacts this depends on comes from: