feat(boxen): A.0 -- vendor termbox2 v2.5.0, build integration, macOS CI#724
Merged
Conversation
…on, macOS CI Vendors termbox2 v2.5.0 (single-header library, MIT) into frontier-cli/third_party/termbox2/ and wires it into the frontier-cli build. Adds macOS CI workflow and placeholder boxen/ directory. Key implementation notes: - termbox2 v2.5.0 is a single-header library (no upstream .c file). termbox2_impl.c is the one TU that defines TB_IMPL to activate the implementation; all other TUs include termbox2.h for declarations only. - TB_IMPL is defined inside termbox2_impl.c (not via Makefile flag) because frontier-cli uses a single-invocation clang build where per-file Makefile CFLAGS overrides are ineffective. - Zero new warnings under clang -std=c17 -Wall -Wextra on macOS. tb2-smoke target: compiles termbox2_impl.c + smoke_main.c as a standalone binary (no frontier-cli deps, no TTY required). Exists so adding Linux/Windows CI later is a CI-config change, not a code change. CI is macOS-only for A.0. frontier-cli uses -fpascal-strings and Mach-O linker flags that are clang/macOS-specific. Linux/Windows CI deferred until a test environment is available. See PHASE_A_MILESTONES.md A.0 scope note for the full rationale. Baselines preserved: 591/591 unit tests pass; integration baseline (21 pre-existing failures) unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bar-raiser: PASS with 5 P2; security: CLEAN with 1 P1 + 2 P2. All addressed in this commit per completionist policy. P1 (security): add permissions: contents: read top-level to boxen-ci.yml. Defense-in-depth against future steps or third-party actions attempting writes / comments / OIDC tokens. P2 (bar-raiser + security overlap): tb2-smoke obj files now land in frontier-cli/obj/tb2-smoke/ (local, gitignored) instead of /tmp. Eliminates predictable-path race risk on shared dev machines; CI runners are unaffected. P2 (bar-raiser): forward-proof comment on smoke_main.c tb_utf8_char_length call explaining why this specific symbol proves TB_IMPL activation -- the definition lives under #ifdef TB_IMPL in termbox2.h around line 1980. Future maintainers will not weaken the smoke into a header-availability check. P2 (bar-raiser): tb2-smoke Makefile recipe gets a comment block explaining the intentional CFLAGS divergence from $(CFLAGS). Recipe uses minimal portable flags so the smoke compiles cleanly on Linux/Windows when those CI jobs land later. P2 (bar-raiser): VERSION file gets a one-line hint showing how to verify the SHA256 pins. Future maintainers can drift-check the vendor drop with a single shasum invocation. P2 (bar-raiser): boxen-ci.yml paths: filter now applies to push: as well as pull_request:. A direct push to develop touching unrelated files no longer triggers the boxen workflow. P2 (security, informational): noted that termbox2/LICENSE and the license header inside termbox2.h have different copyright lines (termbox developers 2021 vs nsf/Adam Saponara). Both are MIT and the attribution is correct; flagged so future maintainers do not "normalize" one into the other. Verified: build clean, tb2-smoke runs, unit 591/591 preserved.
Owner
Author
/gate Round-1 Review @
|
| # | Sev | File | Finding | Action |
|---|---|---|---|---|
| 1 | P1 | .github/workflows/boxen-ci.yml |
Missing top-level permissions: block |
FIXED — added permissions: contents: read |
| 2 | P2 | frontier-cli/Makefile tb2-smoke recipe |
/tmp/tb2_*.o predictable-path race risk on shared dev machines |
FIXED — obj files now in frontier-cli/obj/tb2-smoke/ |
| 3 | P2 | frontier-cli/third_party/termbox2/smoke_main.c |
Future maintainer could weaken tb_utf8_char_length smoke into header-availability check |
FIXED — added forward-proof comment |
| 4 | P2 | frontier-cli/Makefile tb2-smoke recipe |
CFLAGS divergence from $(CFLAGS) not explained |
FIXED — added rationale comment |
| 5 | P2 | frontier-cli/third_party/termbox2/VERSION |
No instructions for SHA256 verification | FIXED — added shasum -a 256 hint |
| 6 | P2 | .github/workflows/boxen-ci.yml |
paths: filter applies to PR but not push |
FIXED — applied to push too |
| info | — | LICENSE attribution | Distinct copyrights in LICENSE (termbox developers 2021) vs termbox2.h header (nsf/Adam Saponara) |
Both correct/MIT; noted for future maintainers |
Reviewer praise
bar-raiser:
- Scope discipline excellent — diff is exactly vendor + build + CI + placeholders + docs
termbox2_impl.ccomment is exemplary, explains why TB_IMPL is in the C file- Smoke test is meaningful:
tb_utf8_char_lengthis declared at h:681 but defined under#ifdef TB_IMPLat h:1980, so the link proves BOTH vendor inclusion AND TB_IMPL activation - Per-file CFLAGS correctly isolates termbox2 from
-fpascal-strings - INCLUDES change is purely additive, no collateral damage to other targets
- Milestone doc honestly captures the macOS-only scope reduction rather than papering over it
security:
- Supply-chain pin integrity verified: shasum matches VERSION exactly; URL/tag/SHA/date/pinner/rationale all present
- No sneak-in: only 5 files in third_party/termbox2/, all ASCII text, no binaries
- Workflow uses
pull_request(notpull_request_target);actions/checkout@v4major-version pinned; no secrets referenced - termbox2 v2.5.0 is the current release from the actively-maintained nsf/Adam Saponara fork; no known public CVEs
Round-2 verification pending.
Owner
Author
/gate Round-2 Review @
|
| # | Round-1 item | Status |
|---|---|---|
| 1 | CI permissions: contents: read block |
FIXED — read-only, no other scopes set, idiomatic placement |
| 2 | tb2-smoke /tmp race risk |
FIXED — obj files in frontier-cli/obj/tb2-smoke/, mkdir -p present, .gitignore covers frontier-cli/obj/ |
| 3 | smoke_main.c forward-proof comment | FIXED — explicit #ifdef TB_IMPL reference + "don't replace" warning |
| 4 | tb2-smoke CFLAGS divergence comment | FIXED — calls out -fpascal-strings + Linux/Windows portability rationale |
| 5 | VERSION shasum verification hint | FIXED — shasum -a 256 termbox2.h LICENSE command added |
| 6 | CI paths: filter under push |
FIXED — push paths now match pull_request paths exactly |
Diff scope: exactly 5 files modified, no creep. No new issues introduced.
Branch ready to merge.
CI on Xcode 15.4 caught a pre-existing bug in debug_handler.c:1179: a
label (after_stepping:) followed directly by a variable declaration is
illegal in C until C23. Local newer-clang accepts it as an extension;
CI's older clang rejects it with "expected expression" at the
declaration.
This bug pre-dates boxen A.0 -- it would have surfaced on any CI
configuration with a strict-enough compiler. The new boxen-ci.yml is
the first build CI in the repo and exposed it on the first run.
Fix: add a single ';' after the label to make it a labeled empty
statement. The original code's intent is preserved exactly.
Pulled into A.0's PR rather than filed separately because:
- A.0 is the PR that introduces CI; the same PR should leave CI
green
- The fix is one character, no risk to A.0's scope
- Blocking A.0 on a separate side-fix would stall the boxen chain
indefinitely
Verified: build clean, unit 591/591 preserved.
Owner
Author
/auto SummaryWhat went well: The plan agent caught the cross-platform reality up front (frontier-cli is Mac-only today; What could improve: The new CI immediately caught a pre-existing label-before-declaration bug at Recommendations: When boxen Phase A continues (A.1 backend interface), pre-flight a quick 🤖 Generated with Claude Code /auto |
16 tasks
jsavin
added a commit
that referenced
this pull request
Jun 7, 2026
Milestone breakdown for Phase B of the boxen plan, mirroring Phase A's structure. Closes #691 (interactive UserTalk debugger TUI). Consumes the substrate shipped in PRs #724-#731 and the runtime contract from PR #722 (thread-debug-attach). Each milestone is sized as a /auto-shaped PR. Includes code-verified corrections to the handoff doc: transport_t write_line takes 3 params (ctx, json, len), not 2 as the handoff doc states. Verified debug/getSource, debug/getStack, and debug/getLocals all exist and their wire formats are documented from source. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First PR in the boxen Phase A chain. Vendors termbox2 v2.5.0, wires it into the frontier-cli build, and adds macOS CI. No boxen code yet — this PR is build infrastructure.
Locked decisions:
9b5a5da862c06c554148c14fd38d2f796be22d57, copied in placetb2-smoketarget exists to keep cross-platform CI a config change rather than a code change later.Discovery during implementation
termbox2 v2.5.0 is a single-header library, not separate
.h/.c. The plan assumed two upstream files; reality is one. The Frontier-authoredtermbox2_impl.cdefinesTB_IMPLand includestermbox2.has a separate translation unit so the implementation symbols are emitted exactly once. Thesmoke_main.cdoes NOT defineTB_IMPL— defining it twice would produce 38 duplicate symbol errors at link time. PHASE_A_MILESTONES.md updated to reflect this.Test plan
make -C frontier-cliclean, no new warningsmake -C frontier-cli tb2-smoke && ./frontier-cli/tb2-smoke→termbox2 vendored OK (tb_utf8_char_length('A') = 1)./tools/run_headless_tests.sh→ 591/591 (baseline preserved)cd tests && make test-integration→ 2186 pass / 21 baseline failures (baseline preserved exactly)frontier-cli/boxen/boxen.hplaceholder exists with header guard.github/workflows/boxen-ci.ymltriggers on this PR (will validate post-push)Files
frontier-cli/third_party/termbox2/termbox2.hfrontier-cli/third_party/termbox2/termbox2_impl.cfrontier-cli/third_party/termbox2/smoke_main.cfrontier-cli/third_party/termbox2/LICENSEfrontier-cli/third_party/termbox2/VERSIONfrontier-cli/boxen/boxen.hfrontier-cli/boxen/README.mdfrontier-cli/Makefile.github/workflows/boxen-ci.ymlthird_party/README.mdplanning/boxen/PHASE_A_MILESTONES.md.gitignorefrontier-cli/tb2-smoke)Net: 3727 insertions / 22 deletions across 12 files. Vast majority is the upstream termbox2.h drop.
Note
This PR introduces the first build/test CI in the repository. Existing
.github/workflows/are claude-bot mention and external monitor only. The new boxen-ci.yml coexists with them.🤖 Generated with Claude Code /auto