Fix RFC 3339 date-time validation with high-precision fractional seconds - #940
Merged
DannyvdSluijs merged 2 commits intoSep 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes RFC 3339 date-time validation for inputs that include more than six fractional-second digits by truncating the fractional component to six digits before passing it to PHP’s DateTimeImmutable::createFromFormat(), while still validating the full original input against the existing RFC 3339 regex.
Changes:
- Truncate the parsed fractional-seconds component to six digits (microseconds) before PHP date parsing to avoid parser limitations.
- Add regression tests covering fractional seconds longer than six digits (including timezone offsets) and an invalid non-digit fractional case.
- Extend
date-timeformat-constraint tests to accept high-precision fractional seconds.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/JsonSchema/Rfc3339.php | Truncates matched fractional seconds to six digits before calling DateTimeImmutable::createFromFormat(). |
| tests/Rfc3339Test.php | Adds valid cases for 7+ fractional digits (Zulu and offset) and an invalid non-digit fractional case. |
| tests/Constraints/FormatConstraintTest.php | Adds a date-time valid format case for 7 fractional digits. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix RFC 3339
date-timevalidation for timestamps containing more than six fractional-second digits.RFC 3339 allows one or more digits in the fractional-second component, but PHP's
DateTimeImmutable::createFromFormat()only accepts up to six microsecond digits.The full input continues to be validated by the existing RFC 3339 pattern. Only the fractional component passed internally to
DateTimeImmutableis truncated to six digits, avoiding PHP's parser limitation without rejecting otherwise valid RFC 3339 timestamps.Regression tests have been added for fractional seconds beyond six digits, including timezone offsets.
Related Issue
Fixes #929
Type of Change
Checklist
Additional Notes
Tested with:
The existing PHPUnit warning is unchanged from the pre-change baseline.