Use case-insensitive comparison for a few IMAP keywords - #2013
Merged
Conversation
Most were already case-insensitive, but a few weren't. This change brings those into line. This fixes s1t5/mail-archiver#511
Contributor
Author
|
I am compelled to admit that I don't actually know the language and don't have either a compiler or enough of a runtime to run any unit tests. I sincerely hope the use of StringComparison is correct. It is at least stunningly similar to other code in the same file. FYI there's another suspicious-looking case in ImapImplementation.cs near line 50, a Dictionary that looks case-sensitive and I think might better be case-insensitive. But I still don't know the language ;) |
jstedfast
approved these changes
Aug 19, 2026
Owner
|
Yikes! I'm embarrassed I somehow missed those! Thanks for the patch and I'll look into the ImapImplementation code as well. |
Contributor
Author
|
Ahem. You realise that I, too, missed the same things in my code? ;) Let's go weep into our beer together at some appropriate time. |
salamiGeek
pushed a commit
to salamiGeek/MailKit
that referenced
this pull request
Aug 25, 2026
Most were already case-insensitive, but a few weren't. This change brings those into line. This fixes s1t5/mail-archiver#511
salamiGeek
pushed a commit
to salamiGeek/MailKit
that referenced
this pull request
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most were already case-insensitive, but a few weren't. This change brings those into line.
This fixes s1t5/mail-archiver#511