Fix URL issue removing get parameters and adding them to post data - #707
Closed
kunitoki wants to merge 4 commits into
Closed
Fix URL issue removing get parameters and adding them to post data#707kunitoki wants to merge 4 commits into
kunitoki wants to merge 4 commits into
Conversation
Member
|
The removal of the juce6 branch automatically closed this PR. Please re-submit against either |
|
Reopened this PR on master branch, see #830 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have post data while using
createInputStream, JUCE will end up removing the get parameters from the endpoint, and append them to the body, breaking both the endpoint to reach and the payload.This also fix
createInputStreamto take astd::functionfor the progress callback instead of a function pointer and void* context.