Skip to content

Fix env missing from non-building WheelhouseTactic#694

Merged
freyes merged 1 commit into
juju:masterfrom
himax16:fix/missing-env-download
Mar 26, 2026
Merged

Fix env missing from non-building WheelhouseTactic#694
freyes merged 1 commit into
juju:masterfrom
himax16:fix/missing-env-download

Conversation

@himax16
Copy link
Copy Markdown
Contributor

@himax16 himax16 commented Mar 26, 2026

Fix the recent changes for WheelhouseTactic failing on non-building state

Checklist

  • Are all your commits [logically] grouped and squashed appropriately?
  • Does this patch have code coverage?
  • Does your code pass make test?

Signed-off-by: Himawan Winarto <himawan.winarto@canonical.com>
Copy link
Copy Markdown
Collaborator

@freyes freyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,. waiting for CI

@freyes
Copy link
Copy Markdown
Collaborator

freyes commented Mar 26, 2026

The ci failure has no relation to this change. I'm merging this patch as it is to fix charm-tools , although we'll need fix the CI too

::                           File "/tmp/tmpvkesiw0w/lib/python3.12/site-packages/pip/_internal/operations/prepare.py", line 76, in _get_prepared_distribution
::                             with build_tracker.track(req, tracker_id):
::                           File "/usr/lib/python3.12/contextlib.py", line 137, in __enter__
::                             return next(self.gen)
::                                    ^^^^^^^^^^^^^^
::                           File "/tmp/tmpvkesiw0w/lib/python3.12/site-packages/pip/_internal/operations/build/build_tracker.py", line 138, in track
::                             self.add(req, tracker_id)
::                           File "/tmp/tmpvkesiw0w/lib/python3.12/site-packages/pip/_internal/operations/build/build_tracker.py", line 104, in add
::                             raise LookupError(message)
::                         LookupError: https://files.pythonhosted.org/packages/be/ec/855654011b4b02037c7c56c4678c02934ed218dd218ba1b0c74ada6ada3b/setuptools_scm-10.0.3.tar.gz (from https://pypi.org/simple/setuptools-scm/) (requires-python:>=3.10) is already being built: setuptools-scm>=7 from https://files.pythonhosted.org/packages/be/ec/855654011b4b02037c7c56c4678c02934ed218dd218ba1b0c74ada6ada3b/setuptools_scm-10.0.3.tar.gz (from -r /tmp/tmpb7lddsf7/wheelhouse.txt (line 35))
::                         [end of output]
::

@freyes freyes merged commit 2463e7a into juju:master Mar 26, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants