feat(relations): watch unit relations #19309
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SubordinateRelationWatcher has been deleted. The functionality will now live in the relation domain's WatchPrincipalLifeSuspendedStatus method.
One is for principal units, the other for subordinates. WatchPrincipalLifeSuspendedStatus implements the logic of the former uniter facade SubordinateRelationsWatcher.
| for _, change := range changes { | ||
| relUUID := corerelation.UUID(change.Changed()) | ||
|
|
||
| changedRelationData, err := s.st.WatchLifeSuspendedStatusMapperData(ctx, relUUID, applicationID) |
Member
There was a problem hiding this comment.
Suggested change
| changedRelationData, err := s.st.WatchLifeSuspendedStatusMapperData(ctx, relUUID, applicationID) | |
| changedRelationData, err := s.st.WatchLifeSuspendedStatusMapperData(ctx, relUUID, applicationID) |
That's starting to read like JavaBeanFactoryVistor...
Comment on lines
+598
to
+599
| eventsource.NamespaceFilter(lifeTableName, changestream.All), | ||
| eventsource.NamespaceFilter(suspendedTableName, changestream.All), |
Member
There was a problem hiding this comment.
Should these not be predicate watchers based on the application ID?
Comment on lines
+708
to
+709
| eventsource.NamespaceFilter(lifeTableName, changestream.All), | ||
| eventsource.NamespaceFilter(suspendedTableName, changestream.All), |
Contributor
|
@hmlanigan is this PR dead? should it be closed? |
Member
Author
|
Closing as a POC, and split into multiple PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uniter facade method WatchUnitRelations now uses the relation domain service rather than state.
Two new watchers have been implemented in the relation service: WatchLifeSuspendedStatus and WatchPrincipalLifeSuspendedStatus. Both watch multiple namespaces and as well as having individual mappers. Functionality from the now defunct SubordinateRelationsWatcher has been reimplemented in the WatchPrincipalLifeSuspendedStatus.
Checklist
Integration tests, with comments saying what you're testingdoc.go added or updated in changed packagesQA steps
Links
Jira card: JUJU-