Support releasing storage (model/apiserver changes) #7648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
changed the title
wallyworld
approved these changes
Jul 18, 2017
| result[i].Error = common.ServerError(err) | ||
| continue | ||
| } | ||
| destroy := a.storage.DestroyStorageInstance |
Member
There was a problem hiding this comment.
The docstring for the containing Destroy method needs updating
Contributor
Author
There was a problem hiding this comment.
Done. Also, I'll be renaming the method to Remove in the next PR, after discussion with Christian.
axw
force-pushed
the
release-storage-controller
branch
from
ec54d73 to
49081db
Compare
Add a new method, State.ReleaseStorageInstance, which atomically marks a storage instance Dying and sets it to "releasing". A storage instance that is being released is one that will be removed from the model without destorying the cloud storage resources.
axw
force-pushed
the
release-storage-controller
branch
from
49081db to
8fd5f42
Compare
Contributor
Author
|
|
Collaborator
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Collaborator
|
Build failed: Tests failed |
Update the Storage API facade to handle the new ReleaseStorage field in the DestroyStorage method's parameters. This is to support a client requesting that storage be non-destructively removed from the model. Update the StorageProvisioner API with new methods for obtaining parameters to destroy volumes and filesystems (distinct from parameters for creating), which include a new field indicating whether or not the storage should be released rather than destroyed.
axw
force-pushed
the
release-storage-controller
branch
from
8fd5f42 to
c770def
Compare
Contributor
Author
|
|
Collaborator
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jul 19, 2017
Release storage client worker provider ## Description of change Add api, cmd, worker/storageprovisioner, and storage provider changes required to support non-destructively removing storage from a model. The `juju remove-storage` command grows a `--no-destroy` flag, which instructs Juju to remove the storage without destroying the associated cloud storage resources. This can be used to release the storage from Juju's control. Once the storage is removed from the model, destroying the model or controller will not destroy the storage. The VolumeSource and FilesystemSource interfaces grow methods for releasing storage, rather than destroying it. The storageprovisioner worker uses these methods for storage that is marked for releasing. Requires #7648 ## QA steps 1. juju bootstrap localhost 2. juju deploy postgresql --storage pgdata=lxd 3. juju remove-storage --force --no-destroy pgdata/0 4. juju destroy-controller localhost 5. lxc storage volume show juju juju-<model-uuid-suffix>-filesystem-0 # use "list" to get the name (volume should remain, but should show no juju-controller-uuid or juju-model-uuid tags) As above, but with EBS. In the portal, you should see the juju-controller-uuid/juju-model-uuid tags are empty after the storage is released/removed. ## Documentation changes Yes, we'll need to document `juju remove-storage --no-destroy`. ## Bug reference None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add state/apiserver support for non-destructively removing storage from a model. This PR is just about modifying the model entities, and updating the storage provisioner API with methods for reporting the new information to a storage provisioner worker.
There will be a followup PR that adds the API client, CLI, worker, and storage provider changes.
QA steps
Smoke test, ensure "remove-storage" works as before.
Documentation changes
None (yet).
Bug reference
None.