Implement add_space and get_spaces#467
Conversation
This PR implements add_space and get_spaces. Since spaces are not implemented with the LXD provider there is not corresponding functional test. Closes issue juju#466.
|
Can one of the admins verify this patch? |
9 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
SimonRichardson
left a comment
SimonRichardson
left a comment
There was a problem hiding this comment.
@manadart can you check this as well 👍
SimonRichardson
left a comment
SimonRichardson
left a comment
There was a problem hiding this comment.
Let's good from my perspective.
|
!!build!! |
|
@gnuoy can you fix the lint issues, then I can land it.
|
|
!!build!! |
|
|
1 similar comment
|
|
|
Failed to build python 3.5, considering it's EOL (#468) we should remove. |
#481 Merge 2.9 into master This is brings in 2.9-rc3 schema as well, so that we're dealing with the latest changes. Conflicts: _client3.py - just re-ran the `make client` as the code is autogenerated. 5e23162 (upstream/master) Merge pull request #480 from SimonRichardson/release-2.8.6 3e23b74 (origin/master, origin/HEAD, master) Merge pull request #479 from SimonRichardson/schema-update-2.8.10 7f96863 Merge pull request #478 from SimonRichardson/scale-typo fd1438c Merge pull request #475 from achilleasa/provide-accessor-for-machine-hostname-field 1015f4d Expand wait_for_idle to support waiting for status (#473) 7829fd0 Merge pull request #471 from SimonRichardson/release-2.8.5 fd36c8f Merge pull request #470 from juju/johnsca/bundle-charm-files-and-wait 3d91d6b Merge pull request #469 from juju/johnsca/accept-charm-files 4e4e108 Merge pull request #465 from juju/johnsca/update-websockets/py39 d696937 Merge pull request #467 from gnuoy/issue/466
4 participants
This PR implements add_space and get_spaces. Since spaces are not
implemented with the LXD provider there is not corresponding
functional test. Closes issue #466.