Expand wait_for_idle to support waiting for status#473
Merged
Conversation
Improve the `Model.wait_for_idle` helper to allow waiting for the workload status to become "active" as well, and to raise on "blocked" status in addition to "error". Also adds log messages to track progress of waiting.
SimonRichardson
approved these changes
Feb 11, 2021
johnsca
added a commit
to charmed-kubernetes/charm-kubernetes-control-plane
that referenced
this pull request
Feb 11, 2021
johnsca
added a commit
to charmed-kubernetes/charm-kubernetes-control-plane
that referenced
this pull request
Feb 11, 2021
* Support for pytest-operator and integration testing Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com> * Run black reformat Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com> * Rework deps in tox and increase tox verbosity in workflow * Fix lint / black error * test self hosted runner Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com> * move easyrsa to machine and not nested container Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com> * Show INFO logs and wait for workload status * Remove actions-operator since we're now using the self-hosted runner * Fix and add logging to post-idle cluster wait * Remove matrix and unnecessary setup from integration test now that we're using the self-hosted runner * Update test to use new helper from juju/python-libjuju#473 * update runner to use vmware Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com> * force python 3.8 for integration test Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com> * reinstall tox from new python Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com> Co-authored-by: Cory Johns <johnsca@gmail.com>
Merged
jujubot
added a commit
that referenced
this pull request
Mar 31, 2021
#481 Merge 2.9 into master This is brings in 2.9-rc3 schema as well, so that we're dealing with the latest changes. Conflicts: _client3.py - just re-ran the `make client` as the code is autogenerated. 5e23162 (upstream/master) Merge pull request #480 from SimonRichardson/release-2.8.6 3e23b74 (origin/master, origin/HEAD, master) Merge pull request #479 from SimonRichardson/schema-update-2.8.10 7f96863 Merge pull request #478 from SimonRichardson/scale-typo fd1438c Merge pull request #475 from achilleasa/provide-accessor-for-machine-hostname-field 1015f4d Expand wait_for_idle to support waiting for status (#473) 7829fd0 Merge pull request #471 from SimonRichardson/release-2.8.5 fd36c8f Merge pull request #470 from juju/johnsca/bundle-charm-files-and-wait 3d91d6b Merge pull request #469 from juju/johnsca/accept-charm-files 4e4e108 Merge pull request #465 from juju/johnsca/update-websockets/py39 d696937 Merge pull request #467 from gnuoy/issue/466
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the
Model.wait_for_idlehelper to allow waiting for the workload status to become "active" as well, and to raise on "blocked" status in addition to "error".Also adds log messages to track progress of waiting.