🎨 Palette: Improve accessibility of icon-only close buttons#15
Conversation
Co-authored-by: julesklord <801266+julesklord@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…bility (#17) Merged PR #17 with conflict resolution against #15: - Applied aria-label for view-file-btn buttons (8 instances) - Preserved descriptive aria-labels from #15 for modal close buttons - Combined learnings in .Jules/palette.md - Resolved: PR #17 originally added generic 'Close modal' labels which conflicted with PR #15's more descriptive labels (e.g., 'Close export dialog')
1 participant
💡 What: Added
aria-labelattributes to multiple close buttons across all modals and the file preview. Also added atitle(tooltip) andaria-labelto the error toast dismiss button.🎯 Why: These buttons previously lacked accessible names, meaning screen readers would likely announce them as "times" or "button", which is unhelpful for users with visual impairments.
📸 Before/After: Before, buttons had no screen reader context. Now, they're explicitly labeled (e.g. "Close export dialog").
♿ Accessibility: Ensures that keyboard and screen-reader users can successfully navigate and dismiss all dialogs in the application.
PR created automatically by Jules for task 13483571534223487664 started by @julesklord