Skip to content

Conversation

odow
Copy link
Member

@odow odow commented Jan 24, 2024

TODO

Basic

  • version field of Project.toml has been updated
    - If a breaking change, increment the MAJOR field and reset others to 0
    - If adding new features, increment the MINOR field and reset PATCH to 0
    - If adding bug fixes or documentation changes, increment the PATCH field

Documentation

  • Add a new entry to docs/src/changelog.md, following existing style

Tests

@odow
Copy link
Member Author

odow commented Jan 24, 2024

There is one new failure in Cbc that is expected, but worth exploring
image

@blegat
Copy link
Member

blegat commented Jan 25, 2024

There is one new failure in Cbc that is expected, but worth exploring

You can remove the ZerosBridge as already done by a few other solvers, e.g.,
https://github.com/jump-dev/CSDP.jl/blob/6f7ea93d9a443f4c4396eaca117aefd40e1a13fc/test/MOI_wrapper.jl#L54

@odow
Copy link
Member Author

odow commented Jan 26, 2024

Yeah, we could work around this in the Cbc tests, but the issue is that we aren't throwing the correct error so things don't work as expected. See #2413

@odow
Copy link
Member Author

odow commented Jan 28, 2024

I removed ZerosBridge from Cbc so it's now passing tests. I'll merge and tag this once CI finishes. #2413 can wait for a longer discussion.

@odow odow merged commit 10d8edc into master Jan 28, 2024
@odow odow deleted the od/v1.25.2 branch January 28, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants