Skip to content

Conversation

@blegat
Copy link
Member

@blegat blegat commented Jun 29, 2020

This PR reuses the LP structures and change_form functions that were present. However, the strategy from building a model from an LP structure is different. Instead of having a custom function that creates an MOIU model from an LP structure, the LP structures are now sub-types of MOI.ModelLike and they implement the read-only MOI API.
It also fills up some tests and the README to make it ready for users to start to play with it.
It still does not cover the use case of users wanting to extract a matrix form from a JuMP or MOI model but that is left as future work :)

@blegat blegat requested a review from joaquimg June 29, 2020 13:34
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@de6863d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   86.14%           
=========================================
  Files             ?        3           
  Lines             ?      166           
  Branches          ?        0           
=========================================
  Hits              ?      143           
  Misses            ?       23           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6863d...e17450a. Read the comment docs.

@blegat blegat merged commit a5373c5 into master Jul 1, 2020
@odow odow deleted the bl/clean_up branch August 23, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants