fix(profile): default usage chart to chronological order#874
Merged
Conversation
Usage over time now remains oldest-left unless a visitor explicitly enables the persisted Newest first preference. This removes the viewport-dependent reversal that made the default differ on wide profiles. Constraint: Existing saved Newest first choices must remain effective after mount Rejected: Remove the preference toggle | Visitors need to retain their explicit visual-order choice Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep implicit chart order chronological; reverse only for an explicit user preference Tested: Frontend ESLint and typecheck; frontend Vitest suite (601 tests) Not-tested: Browser interaction test with real localStorage; SSR regression covers the unset initial render Related: #868
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Closed
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #868
Validation
bun run lint -- src/components/profile/ProfileUsageChart.tsx __tests__/components/profileUsageChart.test.tsxbun run typecheckbun run test(601 tests)Summary by cubic
Default the profile “Usage over time” chart to chronological order on all viewports. Keep the persisted “Newest first” preference and toggle; only an explicit preference reverses the chart. Fixes #868.
Written for commit 88224eb. Summary will update on new commits.