fix: add warning for missing token metadata in spot portfolio - #29
Open
MayurK-cmd wants to merge 1 commit into
Open
fix: add warning for missing token metadata in spot portfolio#29MayurK-cmd wants to merge 1 commit into
MayurK-cmd wants to merge 1 commit into
Conversation
Previously, when token metadata was unavailable from the API, the spot portfolio command would silently skip tokens without warning the user, leading to incomplete or misleading portfolio displays. Changes: - Add console.warn() when token metadata lookup fails - Include mint address in warning for debugging - Add e2e test verifying command handles missing metadata gracefully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: add warning for missing token metadata in spot portfolio
When the
spot portfoliocommand fetches token metadata from the API,if any token's metadata is not found (network failure, new token not
indexed, etc.), the token was silently skipped without warning. This could
lead to users seeing an incomplete portfolio without realizing some
holdings are missing.
Now logs a warning when metadata fetch fails, including the mint address.
Changes:
Fixes: #24