fixing the issues 82 and 130 - #131
Merged
Merged
Conversation
Benchmark: ✅ PASS
|
commit: |
This was referenced Jul 10, 2026
jagguji
added a commit
that referenced
this pull request
Jul 10, 2026
…); bump blend beta pin to 0.0.37-beta.8 (#132) Fixes #107. ## Error-`any` from unresolvable imports (#107) A broken import in a package's `.d.ts` (blend beta.5's `ThemeType` through the shadowed `../tokens` path) makes the checker's **error type** masquerade as `any`. The #31 implicit-generic salvage then emitted a silent type variable — `ThemeProvider`'s `~foundationTokens: 'a=?` with `defects=0` — violating both contract rules at once (`'a` is reserved for round-trip generics; nothing may degrade unflagged). - **Detection**: the checker's `error` intrinsic, checked *before* the salvage — so an author-written `any` in the source can never false-positive (`legitAny: ('a)` keeps the implicit generic; all 89 pre-existing goldens byte-identical). - **Emission**: a 🛑-flagged `string` placeholder with actionable wording ("declared type DOES NOT RESOLVE — broken import in the package's .d.ts; fix the upstream import or hand-match") across all four surfaces: component props, function params/returns, record fields, class members. - **Report**: the Broken bucket explains the type likely EXISTS upstream and the declaration column names the failing reference (`ThemeType`) — hand-matching is a seconds-long fix. react-rating's `itemShapes` now carries the precise cause. Fixture: `error-any-unresolved` (blend's exact shadowed-module shape + author-`any` contrast). ## Benchmark: blend beta pin `0.0.37-beta.5` → `0.0.37-beta.8` Tracks the `beta` dist-tag. Upstream fixed the shadowed `../tokens` import between the two, so `foundationTokens` and the `getAvatarTokens` family now bind their **real types** (`TokensTypes.foundationTokenType`) with zero generator changes — exactly the self-correction path this fix's flags point at. Blend beta.8 scores **222/222 usable, 0 broken / 0 review / 0 loose**, compiles clean. (The #1576 `typeof`-statics duplicates remain — not yet fixed upstream.) Also removes the stray `test/sandbox/src/probe/` files accidentally committed in #131. ## Verification - smoke (3 new #107 checks), all 90 goldens match + compile on ReScript, benchmark identical on all 9 packages - no-false-positive proof: author-`any` fixtures and all pre-existing goldens unchanged 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.