Skip to content

Fix #186: every arm of a views module gets both doors, not just the nameable ones #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jagguji merged 1 commit into from
Aug 7, 2026
Merged

Fix #186: every arm of a views module gets both doors, not just the nameable ones #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions benchmark/baselines/_base-ui-components_react/bindings/CommonTypes.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@
module ValidateTarget = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromArray: array<string> => t = "%identity"
external asArray: t => (array<string>) = "%identity"
external fromPromise: promise<stringOrStringArray> => t = "%identity"
external asPromise: t => (promise<stringOrStringArray>) = "%identity"
external fromUnit: unit => t = "%identity"
Expand Down
30 changes: 30 additions & 0 deletions benchmark/baselines/_juspay_blend-design-system_0.0.36/bindings/HighchartsSharedTypes.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,6 +858,7 @@ type patternObject = {
module ColorType = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromGradientColorObject: gradientColorObject => t = "%identity"
external asGradientColorObject: t => (gradientColorObject) = "%identity"
external fromPatternObject: patternObject => t = "%identity"
Expand Down Expand Up @@ -2517,7 +2518,9 @@ type sonificationSpeechPitchOptions = {
module ChartsSonificationSpeechMappingOptionsPitch = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationSpeechPitchOptions: sonificationSpeechPitchOptions => t = "%identity"
Expand All @@ -2534,7 +2537,9 @@ type sonificationSpeechPlayDelayOptions = {
module ChartsSonificationSpeechMappingOptionsPlayDelay = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationSpeechPlayDelayOptions: sonificationSpeechPlayDelayOptions => t = "%identity"
Expand All @@ -2543,7 +2548,9 @@ module ChartsSonificationSpeechMappingOptionsPlayDelay = {
module ChartsSonificationSpeechMappingOptionsRate = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentTimeOptions: sonificationSpeechPlayDelayOptions => t = "%identity"
Expand All @@ -2552,7 +2559,9 @@ module ChartsSonificationSpeechMappingOptionsRate = {
module ChartsSonificationSpeechMappingOptionsVolume = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentVolumeOptions: sonificationSpeechPlayDelayOptions => t = "%identity"
Expand Down Expand Up @@ -3526,7 +3535,9 @@ type plotColumnrangeBorderRadiusOptions = {
module ChartsSeriesColumnrangeOptionsBorderRadius = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromBorderRadiusOptionsObject: borderRadiusOptionsObject => t = "%identity"
external asBorderRadiusOptionsObject: t => (borderRadiusOptionsObject) = "%identity"
external fromPlotColumnrangeBorderRadiusOptions: plotColumnrangeBorderRadiusOptions => t = "%identity"
Expand Down Expand Up @@ -5483,7 +5494,9 @@ type plotRenkoBorderRadiusOptions = {
module ChartsSeriesRenkoOptionsBorderRadius = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromBorderRadiusOptionsObject: borderRadiusOptionsObject => t = "%identity"
external asBorderRadiusOptionsObject: t => (borderRadiusOptionsObject) = "%identity"
external fromPlotRenkoBorderRadiusOptions: plotRenkoBorderRadiusOptions => t = "%identity"
Expand Down Expand Up @@ -7700,7 +7713,9 @@ type sonificationInstrumentFrequencyOptions = {
module ChartsSonificationInstrumentMappingOptionsFrequency = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentFrequencyOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand All @@ -7709,7 +7724,9 @@ module ChartsSonificationInstrumentMappingOptionsFrequency = {
module ChartsSonificationInstrumentHighpassOptionsFrequency = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentLowpassFrequencyOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand All @@ -7718,7 +7735,9 @@ module ChartsSonificationInstrumentHighpassOptionsFrequency = {
module ChartsSonificationInstrumentHighpassOptionsResonance = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentLowpassResonanceOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand All @@ -7740,7 +7759,9 @@ type sonificationInstrumentPitchOptions = {
module ChartsSonificationInstrumentMappingOptionsPitch = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromStringOrNumbers: array<CommonTypes.stringOrNumber> => t = "%identity"
Expand All @@ -7751,7 +7772,9 @@ module ChartsSonificationInstrumentMappingOptionsPitch = {
module ChartsSonificationInstrumentMappingOptionsPlayDelay = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentPlayDelayOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand All @@ -7760,7 +7783,9 @@ module ChartsSonificationInstrumentMappingOptionsPlayDelay = {
module ChartsSonificationInstrumentMappingOptionsRate = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationTracksRateOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand All @@ -7769,7 +7794,9 @@ module ChartsSonificationInstrumentMappingOptionsRate = {
module ChartsSonificationInstrumentTremoloOptionsDepth = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentTremoloDepthOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand All @@ -7778,7 +7805,9 @@ module ChartsSonificationInstrumentTremoloOptionsDepth = {
module ChartsSonificationInstrumentTremoloOptionsSpeed = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentTremoloSpeedOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand Down Expand Up @@ -30981,6 +31010,7 @@ type exportingMenuObject<'a, 'b, 'c> = {
module ChartsSeriesMapDataGeometryOptionsCoordinates = {
type t
external fromArray: array<float> => t = "%identity"
external asArray: t => (array<float>) = "%identity"
external fromLonLatArrays: array<array<float>> => t = "%identity"
external asLonLatArrays: t => (array<array<float>>) = "%identity"
}
Expand Down
30 changes: 30 additions & 0 deletions ...rk/baselines/_juspay_blend-design-system_0.0.37-beta.8/bindings/HighchartsSharedTypes.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,6 +917,7 @@ type patternObject = {
module ColorType = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromGradientColorObject: gradientColorObject => t = "%identity"
external asGradientColorObject: t => (gradientColorObject) = "%identity"
external fromPatternObject: patternObject => t = "%identity"
Expand Down Expand Up @@ -2576,7 +2577,9 @@ type sonificationSpeechPitchOptions = {
module ChartsSonificationSpeechMappingOptionsPitch = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationSpeechPitchOptions: sonificationSpeechPitchOptions => t = "%identity"
Expand All @@ -2593,7 +2596,9 @@ type sonificationSpeechPlayDelayOptions = {
module ChartsSonificationSpeechMappingOptionsPlayDelay = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationSpeechPlayDelayOptions: sonificationSpeechPlayDelayOptions => t = "%identity"
Expand All @@ -2602,7 +2607,9 @@ module ChartsSonificationSpeechMappingOptionsPlayDelay = {
module ChartsSonificationSpeechMappingOptionsRate = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentTimeOptions: sonificationSpeechPlayDelayOptions => t = "%identity"
Expand All @@ -2611,7 +2618,9 @@ module ChartsSonificationSpeechMappingOptionsRate = {
module ChartsSonificationSpeechMappingOptionsVolume = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentVolumeOptions: sonificationSpeechPlayDelayOptions => t = "%identity"
Expand Down Expand Up @@ -3585,7 +3594,9 @@ type plotColumnrangeBorderRadiusOptions = {
module ChartsSeriesColumnrangeOptionsBorderRadius = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromBorderRadiusOptionsObject: borderRadiusOptionsObject => t = "%identity"
external asBorderRadiusOptionsObject: t => (borderRadiusOptionsObject) = "%identity"
external fromPlotColumnrangeBorderRadiusOptions: plotColumnrangeBorderRadiusOptions => t = "%identity"
Expand Down Expand Up @@ -5542,7 +5553,9 @@ type plotRenkoBorderRadiusOptions = {
module ChartsSeriesRenkoOptionsBorderRadius = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromBorderRadiusOptionsObject: borderRadiusOptionsObject => t = "%identity"
external asBorderRadiusOptionsObject: t => (borderRadiusOptionsObject) = "%identity"
external fromPlotRenkoBorderRadiusOptions: plotRenkoBorderRadiusOptions => t = "%identity"
Expand Down Expand Up @@ -7759,7 +7772,9 @@ type sonificationInstrumentFrequencyOptions = {
module ChartsSonificationInstrumentMappingOptionsFrequency = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentFrequencyOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand All @@ -7768,7 +7783,9 @@ module ChartsSonificationInstrumentMappingOptionsFrequency = {
module ChartsSonificationInstrumentHighpassOptionsFrequency = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentLowpassFrequencyOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand All @@ -7777,7 +7794,9 @@ module ChartsSonificationInstrumentHighpassOptionsFrequency = {
module ChartsSonificationInstrumentHighpassOptionsResonance = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentLowpassResonanceOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand All @@ -7799,7 +7818,9 @@ type sonificationInstrumentPitchOptions = {
module ChartsSonificationInstrumentMappingOptionsPitch = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromStringOrNumbers: array<CommonTypes.stringOrNumber> => t = "%identity"
Expand All @@ -7810,7 +7831,9 @@ module ChartsSonificationInstrumentMappingOptionsPitch = {
module ChartsSonificationInstrumentMappingOptionsPlayDelay = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentPlayDelayOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand All @@ -7819,7 +7842,9 @@ module ChartsSonificationInstrumentMappingOptionsPlayDelay = {
module ChartsSonificationInstrumentMappingOptionsRate = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationTracksRateOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand All @@ -7828,7 +7853,9 @@ module ChartsSonificationInstrumentMappingOptionsRate = {
module ChartsSonificationInstrumentTremoloOptionsDepth = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentTremoloDepthOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand All @@ -7837,7 +7864,9 @@ module ChartsSonificationInstrumentTremoloOptionsDepth = {
module ChartsSonificationInstrumentTremoloOptionsSpeed = {
type t
external fromString: string => t = "%identity"
external asString: t => (string) = "%identity"
external fromNumber: float => t = "%identity"
external asNumber: t => (float) = "%identity"
external fromFunction: JsFn.t => t = "%identity"
external asFunction: t => (JsFn.t) = "%identity"
external fromSonificationInstrumentTremoloSpeedOptions: sonificationInstrumentFrequencyOptions => t = "%identity"
Expand Down Expand Up @@ -31040,6 +31069,7 @@ type exportingMenuObject<'a, 'b, 'c> = {
module ChartsSeriesMapDataGeometryOptionsCoordinates = {
type t
external fromArray: array<float> => t = "%identity"
external asArray: t => (array<float>) = "%identity"
external fromLonLatArrays: array<array<float>> => t = "%identity"
external asLonLatArrays: t => (array<array<float>>) = "%identity"
}
Expand Down
1 change: 1 addition & 0 deletions benchmark/baselines/_juspay_blend-design-system_0.0.37/bindings/DirectoryTypes.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ type directoryVirtualizationConfig = {
module DirectoryExpandedItems = {
type t
external fromArray: array<string> => t = "%identity"
external asArray: t => (array<string>) = "%identity"
external fromSet: Set.t<string> => t = "%identity"
external asSet: t => (Set.t<string>) = "%identity"
}
Loading
Loading