Skip to content

Allow scoped HTTP homelab connectors - #52

Merged
jusso-dev merged 1 commit into
mainfrom
agent/allow-homelab-http-connectors
Jul 27, 2026
Merged

Allow scoped HTTP homelab connectors#52
jusso-dev merged 1 commit into
mainfrom
agent/allow-homelab-http-connectors

Conversation

@jusso-dev

@jusso-dev jusso-dev commented Jul 27, 2026

Copy link
Copy Markdown
Owner

What changed

  • Mark environment-bootstrapped HTTP connector URLs as scoped connector test mode.
  • Keep HTTPS connectors in normal production protocol mode.
  • Add a focused unit regression for HTTP versus HTTPS bootstrap behaviour.

Root cause

Muster's governed egress permits HTTP only when the connector's testMode is true. Homelab Tawny and Kelpie are deliberately internal HTTP services, but environment bootstrap always stored testMode: false. Live Slack grounding therefore reached the connectors and was denied with egress_denied: Connector protocol is not allowed.

The environment bootstrap path continues to store these integrations as mock: false; only the per-connector protocol policy changes. Host allowlists and private-network controls remain enforced.

Validation

  • pnpm --dir packages/database typecheck
  • pnpm --dir packages/database test -- src/bootstrap-connectors.test.ts — 12 passed, 4 opt-in integration tests skipped
  • git diff --check

Live Slack Tawny/Kelpie proofs will run after homelab deployment.

Summary by CodeRabbit

  • New Features

    • Environment connectors using HTTP endpoints now automatically operate in test mode.
  • Bug Fixes

    • Improved connector configuration so HTTPS endpoints remain disabled for test-mode behavior.
    • Added coverage to verify protocol-based connector behavior.

@jusso-dev
jusso-dev merged commit 0f83986 into main Jul 27, 2026
2 of 4 checks passed
@jusso-dev
jusso-dev deleted the agent/allow-homelab-http-connectors branch July 27, 2026 07:47
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ba2c0e41-30a9-4a66-83dd-a509e0e40c89

📥 Commits

Reviewing files that changed from the base of the PR and between f44fdc4 and 0872ac3.

📒 Files selected for processing (2)
  • packages/database/src/bootstrap-connectors.test.ts
  • packages/database/src/bootstrap-connectors.ts

📝 Walkthrough

Walkthrough

Environment connector bootstrap now derives testMode from the base URL protocol. HTTP endpoints enable test mode, while HTTPS endpoints do not. A Vitest suite verifies both cases.

Changes

Environment connector test mode

Layer / File(s) Summary
Protocol-based connector configuration
packages/database/src/bootstrap-connectors.ts, packages/database/src/bootstrap-connectors.test.ts
The exported environmentConnectorTestMode helper returns true for http: URLs, bootstrap configuration uses it for testMode, and tests verify HTTP and HTTPS behavior.

Estimated code review effort: 2 (Simple) | ~5 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/allow-homelab-http-connectors

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant