Skip to content

1.3.2

Choose a tag to compare

View all tags
@zoltan-sule zoltan-sule released this 14 Sep 17:17
· 18 commits to 1.x since this release
1.3.2
3c63ded
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

Two bug fixes. No API changes, nothing deprecated, safe to update from any 1.3.x.

Fixed

paginate() produced a negative offset for page numbers below 1

($page - 1) * $maxPerPage was used unclamped, so ?page=0 ended up as offset=-100. Both arguments are now clamped, which also absorbs null, non-numeric and float page numbers instead of throwing a TypeError or an InvalidArgumentException.

findPoliticalDistricts() always returned an empty array

BasicDataQuery::findPoliticalDistricts() called callRegions() instead of callPoliticalDistricts(), so it fetched /objekt/regionen and handed that response to the district wrapper. The wrapper looks for politischer_bezirk elements, which a regions response never contains, so it silently returned []. Neither side errored, which is why it went unnoticed since political districts were added in 1.3.0.

Because the district list came back empty, valid district ids could not be discovered either, which made filterByPoliticalDistrictId() unusable as well. Both work now.

Upgrading

Nothing to do. If you previously worked around findPoliticalDistricts() returning nothing, that workaround can be removed.

Assets 2
Loading