Fix sequential awaited calls in Asyncify runtimes#265
Open
TheBoyWhoLivedd wants to merge 2 commits into
Open
Conversation
Generate async cwrap bindings whenever an exported function may suspend, including in release builds. Add an asynchronous pending-job driver so guest jobs can safely resume through multiple awaited host calls without corrupting the runtime.
The build regenerates and formats variant FFI files from scripts/generate.ts. Exclude those generated outputs so the pull request contains only canonical source changes.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes runtime corruption caused by multiple sequential awaited host calls within one guest execution.
{ async: true }for Asyncifycwrapbindings in release builds.QuickJSAsyncRuntime.executePendingJobsAsync().Cause
The generated debug bindings passed
{ async: true }to Emscripten'scwrap, but release bindings omitted it.Emscripten requires this option when a wrapped export may suspend. Without it, a release build can continue as though the call returned synchronously, leaving the runtime in an invalid state.
QTS_ExecutePendingJob_MaybeAsyncmay suspend when a pending guest job calls an asyncified host function, so Asyncify runtimes also need an awaitable pending-job driver:Reproduction
https://github.com/TheBoyWhoLivedd/quickjs-emscripten-asyncify-multi-await-repro
Fixes #258