[MEDIUM] Isolate gem builds from release credentials - #755
Merged
anakinj merged 2 commits intoSep 5, 2026
Conversation
anakinj
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The current tag job grants
id-token: write, configures RubyGems credentials, creates a GitHub write-token remote, and then runsbundle installplusrake releasein the same job. GitHub token and OIDC permissions apply to the complete job, so compromised build-time dependency code can run while publishing identities are available.This split keeps gem construction in a
contents: readjob. The publishing job receives only the already-built artifact, configures trusted publishing immediately beforegem push, and has no checkout or dependency installation. The final propagation check also uses the same artifact without release credentials.Verification
v3.2.1.jwt-3.2.1.gemsuccessfully on rbenv Ruby 4.0.6.jwt:3.2.1:rubytuple from the built artifact.git diff --check.I did not perform a live GitHub Actions release or publish a gem.
Breaking changes
None for runtime or package contents. This changes release orchestration only: the workflow now publishes the artifact produced by the preceding build job.