hack/collectlogs: make ORC pod log collection more robust#841
Merged
Conversation
Resolve the pod name explicitly instead of relying on a label selector, capture stderr from kubectl logs into the log file, and detect empty log files with a --previous fallback. Closes k-orc#839
Collaborator
Author
|
OK good, all 3 artifacts contain ORC pod logs. I'll now drop the last commit that was used for testing. |
mandre
force-pushed
the
debug-pod-log-collect
branch
from
eb603c5 to
5502581
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
winiciusallan
approved these changes
Jul 7, 2026
Collaborator
Author
|
One of the jobs failed due to a race, which I'm hopefully fixing with #843. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve the pod name explicitly instead of relying on a label selector,
capture stderr from kubectl logs into the log file, and detect empty log
files with a --previous fallback.
Closes #839