docs(tr): Phase L implementation plans (L-0..L-7)#9
Conversation
|
@cursor review |
8 sub-phases per the canonical Phase L design at docs/superpowers/specs/2026-04-17-tr-library-design.md (PR #3). Tests mandatory in every sub-phase (4-layer pattern: equivalence / C ABI / Python wrapper / sweep smoke). Existing tr2 executable preserved; libtrapi.so added as a new build target.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Pre-merge review (parent agent + code-reviewer agent)PR を draft 化 します。merge 前に以下の修正が必要です。 Critical (compile-blocking)
Important
修正方針
NotePR #4 (tr Phase 1, USE ONLY 整備) と本 PR (tr Phase L plans) は独立。PR #4 は別途進行。 修正後 |
|
@cursor review |
…dispatch, L-3 tr_loop arg, L-2/L-4 SRCM note)
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
2 issues from previous reviews remain unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a376f95. Configure here.
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3a68373. Configure here.
| def test_tst2(self): | ||
| from python.trlib.tests.fixtures.tst2_params import apply | ||
| actual = run_case(apply, ntmax=10) | ||
| compare_with_baseline(actual, BASELINES / "tr_tst2") |
There was a problem hiding this comment.
Wrong import path for test fixture modules
Medium Severity
The test templates use from python.trlib.tests.fixtures.iter01_params import apply (and similarly for m0904_params, tst2_params), but the same file adds REPO / "python" to sys.path at line 149, which makes trlib — not python.trlib — the correct top-level package. The python.trlib path only works accidentally when CWD happens to be the repo root. This is also inconsistent with from trlib import Trlib used in the same file. The imports need to be from trlib.tests.fixtures....
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3a68373. Configure here.
1 participant
Phase L plans for tr module library-ization, per the design spec merged in PR #3 (docs/superpowers/specs/2026-04-17-tr-library-design.md). 8 sub-phases (L-0 baseline, L-1 graphics split, L-2 C ABI foundation, L-3 param registry, L-4 shared-lib build, L-5 Python wrapper, L-6 4-layer tests, L-7 docs). Tests mandatory; existing tr2 binary preserved; libtrapi.so added as new target.
Note
Low Risk
Documentation-only change adding implementation plans; no runtime/code paths are modified, so risk is limited to potential confusion if plans become outdated.
Overview
Adds a new set of Phase L implementation plan documents (
docs/superpowers/plans/2026-04-18-tr-library-L0..L7-*.md) that lay out the step-by-step roadmap for TR “library-ization”.The plans cover: baseline confirmation, a Makefile-only split of
trsources into core/graphics/menu, scaffolding a C ABI (tr_init/tr_run/...) and state struct, buildinglibtrapi.sovia PIC rebuilds of dependent libs, a stdlib-only Pythonctypeswrapper, integrating a 4-layer test strategy intorun_tests.sh, and final user-facing docs/examples—explicitly aiming to keep the existingtr2binary behavior unchanged throughout.Reviewed by Cursor Bugbot for commit 3a68373. Bugbot is set up for automated code reviews on this repo. Configure here.